Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove CIMV and CTMV. #368

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Jun 24, 2022

With #353, these are no longer needed.

Context with the help of @prestwich: Bitcoin introduced equivalents to these instructions in order to implement them as a soft fork: verify instructions don't push a value onto the stack (during Bitcoin Script verification). We don't have such a limitation, so we can just directly read the maturity value from the input/transaction and compare against it.

Implementation:

@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Jun 24, 2022
@adlerjohn adlerjohn self-assigned this Jun 24, 2022
@adlerjohn adlerjohn changed the title Remove CIMV and CTMV. Remove CIMV and CTMV. Jun 24, 2022
@adlerjohn adlerjohn merged commit f257073 into master Jun 24, 2022
@adlerjohn adlerjohn deleted the adlerjohn/remove-check-verify-instrs branch June 24, 2022 17:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
comp:FVM Component: FuelVM
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants